rainbow-delimiters was removed in 87b616e, but some of its activation
hooks were restored in 3b58741 and not removed when merged into
`master`.
Fix: #8483
Ref: 87b616e5d8
Amend: 3b58741522
tree-sitter/zig-tree-sitter is written in zig, so cannot be
automatically installed (`treesit-install-language-grammar` expects
C-based grammars).
Amend: 9acc5f48b6
My mistake: I'd overlooked that rustic-mode already provides treesit
support, so we don't need all this complexity, we can simply use
rustic-mode. This indirectly fixes the recent regressions around
localleader keybinds and LSP activation.
Fix: #8473
Amend: 086a0d30d0
With af4cbc7, escaping and quoting in $EMACS is now respected by
bin/doom; so make use of it to fix issues with $EMACS paths/commands
that contain spaces.
Ref: af4cbc7791d2
Fix: #8475Fix: #8403
bin/doom couldn't handle spaces in $EMACS, but worse than that, they
couldn't be quoted or escaped. This commit addresses the latter.
Fix: #8475Fix: #8403
If the base major mode doesn't exist, let's assume we want no
fallthrough for this major mode (in the event the grammar isn't ready)
and simply push forward anyway, even if a missing grammar results in a
broken state.
This will particularly affect major modes like `typescript-mode` (which
simply won't be installed if +tree-sitter is enabled) and
`go-{mod,work}-ts-mode` (for which no base major modes exist).
The difference (generally) between most base and ts-modes is
performance, not features, so "gracefully failing back to the base mode"
makes sense UX-wise, but `typescript-mode` notably inferior to
`typescript-ts-mode` (particularly in its TSX support). Beginners may
misidentify its shortcomings as bugs, so it's better to simply error out
early so the user can be made aware of the problem sooner and less
ambiguously.
In Emacs <=30, top-level `treesit-ready-p` calls in various *-ts-mode
packages (like lua-ts-mode or ruby-ts-mode) are commonplace, and they
throw up a warning popup if the grammar isn't available at load time.
This is intrusive. Instead, this forces it to log to *Messages* instead
before falling back to the normal major mode.
Fortunately, these top-level `treesit-ready-p` calls have been removed
in most *-ts-mode packages in 31+, but this still impacts users on <=30
or using third party *-ts-modes that haven't adapted.
However, this doesn't suppress the warning when opening a *-ts-mode.el
file (thanks to the byte-compiler).
`major-mode-remap`, `major-mode-remap-alist`, and
`major-mode-remap-defaults` were not backported correctly for Emacs 29,
28, and 27 users.
Amend: da08aa2d7d
I removed the grammar recipes in 3b58741 to avoid redundancy with the
upstream recipes, but didn't realize that those upstream recipes weren't
added until Emacs 31, so users on 30 and older would get errors when
trying to install any missing grammars.
This also establishes a hard dependency between :lang (php +tree-sitter)
and :lang ({javascript,web} +tree-sitter).
Amend: 3b58741522
From this point on, Straight will download packages from tarballs (if
possible) from their associated forge rather than clone them as git
repositories. This is (marginally) faster and consumes significantly
less space. Doom treats its packages as build artifacts anyway.
This shouldn't cause any immediate breakage, but it may upset folks who
want their local package installs to be repositories. For them, this can
be reversed by simply adding this to $DOOMDIR/init.el:
(after! doom-straight
(setq straight-vc-use-snapshot-installation nil))
This only applies to packages installed after this point. Packages that
are already cloned as a repo will stay that way until the next time
they're uninstalled or reinstalled from scratch. Plus it only works on
systems that have `tar` in their $PATH *and* forges that are
supported (at the time of writing: github, gitlab, codeberg, bitbucket,
and sourcehut).
Ref: radian-software/straight.el@4241b63952
BREAKING CHANGE: The PHP API data file no longer exists on php.net, and
there is no substitute, and php-extras is no longer maintained, so this
package is defunct and leaves php buffers in an error state. This
deprives non-LSP users from eldoc and naive code completion. The
alternative is to simply adopt LSP.
Bad-ptr/persp-mode.el@f146ddccaf -> Bad-ptr/persp-mode.el@82680795b3
this fixes a nasty bug where new eglot workspaces corrupt the previous
one. symptoms of this can be your definition jump source buffer being
read-only and renamed to:
`*EGLOT (jump-destination-project/(your-lang-mode)) stderr*`
When you fail to provide a correct commit message, it may just become
lost without this adjustment.
(fun fact: this feature was used to fix its own commit message 4 times)
BREAKING CHANGE: This commit removes a number of core packages and
features from this module and only replaces a handful of them, so that
we can lean more on LSP and tree-sitter. To be specific:
- We used to rely on `rjsx-mode` (derived from js2-mode) for total
JS/JSX support (though imperfect; Emacs was starved for options at the
time). This has now been replaced with `js-ts-mode` (built-in after
Emacs 29), falling back to `js-mode` (very rudimentary, but a decent
fallback).
- This also meant the removal of `js2-mode`, which `skewer-mode`,
`js2-refactor`, and `xref-js2` depended on, so those were removed
too, and have *somewhat* been replaced with LSP integration (offers
jump-to-definition/references and *some* refactoring actions, but no
replacement for skewer's functionality).
- Typescript support no longer relies on the jury-rigged, web-mode-derived
major mode (because TSX support in the upstream `typescript-mode`
isn't great). We now use `typescript-ts-mode` (built-in into Emacs
29.1+), falling back to `typescript-mode`.
- JSX/TSX support now *requires* tree-sitter (and Emacs 29.1+), where
`tsx-ts-mode` is available and outshines all the alternatives (at the
time of writing).
Due to the absolute chaos that is webdev, this module sacrifices some of
the graceful-degradation I've implemented for other modules and creates
a hard requirement on tree-sitter and Emacs 29.1+ for JSX/TSX. It still
tries to degrade gracefully for plain JS and TS, but the module's doctor
and docs will actively recommend tree-sitter.
Close: #5278Fix: #6172Fix: #7042Close: #8447
Co-authored-by: ribaricplusplus <ribaricplusplus@users.noreply.github.com>
The notmuch/compose function allows selecting between the email
addresses that the user has configured, but the email address is used
directly in the From header. Messages display much nicer in people's
inbox when the From contains a name in addition to an emeail address, so
construct the From header with the user's name as well as the chosen
email address.
Signed-off-by: Stephen Brennan <stephen@brennan.io>
