Due to magit now using server-done instead of server-edit as of
magit/magit@5c02910, which calls server-done-hook, which the workspaces
module has a hook on to kill auto-generated, daemon-spawned frames,
causing workspaces to be prematurely killed when commiting in magit.
- Remove remaining `EMACS27+` checks, since the whole codebase is
assumed to run at version 27 or above now
- Remove `EMACS27+` definition since it's no longer needed
(interactive "PD") was incorrectly used to pass two interactive
arguments to the command, but only the first argument was sent.
This corrects that, refactors +tmux/cd to be easier to understand, and
updates its docstring to reflect these changes.
A sufficiently up-to-date version of this package is built into Emacs
27.1+. Since we dropped 26.x support in 044a1a5f2 this is no longer
needed.
Mentioned in https://discourse.doomemacs.org/t/1180
Currently <kbd>SPC g L</kbd> runs `magit-log` which opens a context
window for git log with an option selected that limits the log to the
file open in buffer. The user then has to press <kbd>l</kbd> to actually
see the log. The same result can be achieved by calling
`magit-log-buffer-file` instead
When Emacs 26.x support was in place this was originally:
```elisp
lsp-ui-sideline-actions-icon (if EMACS27+ lsp-ui-sideline-actions-icon-default)
```
But when it was removed it became:
```elisp
lsp-ui-sideline-actions-icon t
```
The docs for lsp-ui-sideline-actions-icon say:
```
Image file for actions. It must be a png file.
```
Setting this to `t` results in a whole lot of these messages:
```
[lsp-ui-sideline]: Error with actions icon: (error Invalid image specification)
```
So the solution seems to me to be to set it to:
```elisp
lsp-ui-sideline-actions-icon lsp-ui-sideline-actions-icon-default
```
I've set it in my emacs and it seems to work.
Our advice is no longer needed, now that envrc provides
envrc-propagate-environment. We also cache the executable path (benefits
TRAMP users, in particular).
Emacs 27.x has been the stable version of Emacs for nearly a year, and
introduces a litany of bugfixes, performance, and quality-of-life
improvements that significantly reduce Doom's maintenance burden (like
XDG support, early-init.el, image manipulation without imagemagick, a
native JSON library, harfbuzz support, pdumper, and others).
With so many big changes on Doom's horizon, I like having one less (big)
thing to worry about.
Also reverts bb677cf7a (#5232) as it is no longer needed.
In the PDF module, there is a macro that is used to prevent the
file-too-big prompt for PDFs since they're always too big. However, this
macro has an extra variable listed that then gets passed on to the
wrapped function and causes an error if the function doesn't support the
extra variable.
This fix simply checks if the extra value is present or not and only
calls the wrapped function with it if is actually present. After all,
the variable will still be nil even if nil isn't passed.
