fix(lib): doom-copy: copy first level of records

Regardless of DEEP?, a record's fields should be copied one level deep
at least, to ensure shallow changes to shallow copies don't affect the
original.

Amend: 169540ad3b
This commit is contained in:
Henrik Lissner
2024-12-03 17:42:52 -05:00
parent 637f70f53b
commit 82cfe98ccc

View File

@ -334,12 +334,10 @@ TRIGGER-HOOK is a list of quoted hooks and/or sharp-quoted functions."
(cl-defgeneric doom-copy (val &optional deep?)
"Return a (optionally deep) copy of VAL."
(if (recordp val) ; `record' specializer not supported until Emacs 30
(if deep?
(cl-loop with newval = (copy-sequence val)
for idx from 1 to (length (cdr (cl-struct-slot-info (type-of val))))
do (aset newval idx (doom-copy (aref newval idx) t))
finally return newval)
(copy-sequence val))
(cl-loop with newval = (copy-sequence val)
for idx from 1 to (length (cdr (cl-struct-slot-info (type-of val))))
do (aset newval idx (doom-copy (aref newval idx) deep?))
finally return newval)
(cl-check-type val (or integer float boolean symbol null))
val))