awesome-emacs/org-roam
1
0
Fork 0
mirror of https://github.com/org-roam/org-roam synced 2025-08-01 12:17:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

(internal): remove org-roam--get-title-or-slug function (#1284)

Browse Source 
Every file has a title when saved into the database, so this function is
redundant in most cases (e.g. in org-roam-buffer, where backlinks are
fetched from the database).
This commit is contained in:
Jethro Kuan
2020-11-15 19:44:36 +08:00
committed by GitHub
parent baf0dd9d00
commit face683e00
5 changed files with 15 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
org-roam.el
View File

@ -796,11 +796,6 @@ Each ref is returned as a cons of its type and its key."
(file-relative-name (expand-file-name org-roam-directory))
(file-name-sans-extension)))
(defun org-roam--get-title-or-slug (path)
"Convert `PATH' to the file title, if it exists. Else, return the path."
(or (org-roam-db--get-titles path)
(org-roam--path-to-slug path)))
(defun org-roam--title-to-slug (title)
"Convert TITLE to a filename-suitable slug."
(cl-flet* ((nonspacing-mark-p (char)
@ -1772,7 +1767,7 @@ Return added tag."
(interactive)
(let* ((roam-buffers (org-roam--get-roam-buffers))
(names-and-buffers (mapcar (lambda (buffer)
(cons (or (org-roam--get-title-or-slug
(cons (or (org-roam-db--get-title
(buffer-file-name buffer))
(buffer-name buffer))
buffer))
@ -1855,7 +1850,8 @@ the executable 'rg' in variable `exec-path'."
(let ((rowcol (concat row ":" col)))
(insert "- "
(org-link-make-string (concat "file:" file "::" rowcol)
(format "[%s] %s" rowcol (org-roam--get-title-or-slug file))))
(format "[%s] %s" rowcol (or (org-roam-db--get-title file)
file))))
(when (executable-find "sed") ; insert line contents when sed is available
(insert " :: "
(shell-command-to-string
@ -1871,7 +1867,6 @@ the executable 'rg' in variable `exec-path'."
(highlight-phrase (downcase title) 'bold-italic))
(goto-char (point-min))))))
;;;###autoload
(defun org-roam-version (&optional message)
"Return `org-roam' version.