featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.
featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.
Notmuch, like org, uses git describe to build a version string variable
at install time, but Doom preforms shallow clones of its packages, where
git describe does not work.
Notmuch is one of our bigger packages and the variable isn't essential
for normal use, so I've opted to build notmuch-version.el by hand. It
lacks the commit offset, but it has enough information to work with.
Fix#5581
- Rename module from `:completion selectrum` to `:completion vertico`
- Rename all files involved
- Do *not* yet rename all the functions, as that messes up git's rename
detection.
