In the interest of slimming down Doom's core (as we near v3), I've
deprecated these macros. They doesn't really need to exist. Sure, the
alternatives aren't as ergonomic or elegant, but they're good enough
that we don't need these trivial wrappers. Their local uses have been
refactored out as well.
Since dumb-jump-go is deprecated, we want to use the xref backend.
Due to how lsp-mode integrates with xref-backend-functions currently,
it's not as simple as just adding dumb-jump-xref-activate to the
xref-backend-functions so this is a bit of a hacky workaround.
BREAKING CHANGE: This removes the pcre2el package, which Doom was using
solely for one function to escape PCREs. In the interest of thinning out
Doom's core, I've hoisted a simpler version of the function into Doom's
stdlib so I can remove the dependency.
Given a relative file path that:
- Doesn't exist, relative to the open file/buffer (default-directory),
- Doesn't exist, relative to the project root,
- Doesn't satisfy any of the other rules in ffap-alist,
- Contains more than one segment (forward slashes),
The +lookup/file command will walk the file tree from default-directory
to the project root to search for the path, so given:
project
└── src
├── a
│ └── a.h
└── b
└── b.h
This command, run on 'b/b.h' in a/a.h, will open b/b.h (but 'b.h' alone
won't work, which is intended, to reduce false positives).
Close: #7890
Co-authored-by: liuzhishan <liuzhishan@users.noreply.github.com>
BREAKING CHANGE: This deprecates the IS-(MAC|WINDOWS|LINUX|BSD) family
of global constants in favor of a native `featurep` check:
IS-MAC -> (featurep :system 'macos)
IS-WINDOWS -> (featurep :system 'windows)
IS-LINUX -> (featurep :system 'linux)
IS-BSD -> (featurep :system 'bsd)
The constants will stick around until the v3 release so folks can still
use it -- and there are still some modules that use it, but I'll phase
those uses out gradually.
Fix: #7479
featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.
featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.
doom-enlist is now a deprecated alias for ensure-list, which is built
into Emacs 28.1+ and is its drop-in replacement. We've already
backported it for 27.x users in doom-lib (in 4bf4978).
Ref: 4bf49785fd
Xref started many backwards incompatible changes in the name of
performance. The marker ring no longer exists as a variable.
+lookup--xref-show will silently fail every time.
Switches to using xref-after-jump-hook to test whether xref actually
jumped to a definition. The hook is part of the exposed interface and
should hopefully not change in the near future.
Fix: #5737
Setting the rules explicitly was preventing users from customizing how
xwidget popups should behave, so it was moved to the popup module as a
global default.
- Rename module from `:completion selectrum` to `:completion vertico`
- Rename all files involved
- Do *not* yet rename all the functions, as that messes up git's rename
detection.
- move `consult-xref` stuff to `:tools lookup` where it belongs
- add selectrum functionality where possible, document what's beyond the
scope of this PR
gf (+lookup/file) has been changed to:
+ Use the active selection instead of the filename-at-point when
searching for a file (as requested in #4942).
+ Pre-fill the FFAP prompt with the thing at point if no obvious
filepath can be guessed from it (via ffap-alist).
+ Offer to search the current project for the thing-at-point (if
counsel-file-jump is available).
+ Fall back to a standard ffap prompt if all else fails.
I've also reversed te order of file lookup backends so that our FFAP
backend is treated as a never-failing last resort (also because the
bug-reference backend is known to fail gracefully, so we can trust it to
run first).
Closes#4942
Formerly, `+lookup/in-docsets` would disregard
dash-docs-browser-func (locally setting it to the value of
`+lookup-open-url-fn`). Now only `+lookup/online` respects
+lookup-open-url-fn and `+lookup/in-docsets` respects
`dash-docs-brwoser-func`.
Closes#4795
And disable bug-reference-mode by default. It produces too many false
positives, particularly in web modes where color hexes in strings and
comments are very common. Now that bug-reference support is built into
+lookup/file (on gf), users can use that instead.
- Fixes: `set-lookup-handlers!` couldn't define :definition or
:references handlers in text-mode derivatives.
- Adds: support for evaluating code in jupyter blocks (#2477).
Remove :tools/lookup +xwidget. Provide
`+lookup-xwidget-webkit-open-url-fn` so that we can manually configure
Xwidget WebKit browser for `+lookup/online` or `+lookup/in-docsets`.
