Commit Graph

71 Commits

Author SHA1 Message Date
bca4265e64 fix(vertico): fix display with embark-act-all 2025-03-13 01:02:08 -04:00
bc3f0ce718 fix(vertico): void-function consult--async-split-style error
Amend: ffc5c60721
Fix: #8282
Ref: minad/consult@bdc4a9724c
2025-02-25 22:06:06 -05:00
0a715cc3f2 refactor: (if|when)-let -> (if|when)-let*
With the former macros' future in the air (and likely to be targeted in
future, potentially breaking changes), I'll deal with this now than have
it bite me later.

Ref: https://lists.gnu.org/archive/html/emacs-devel/2024-10/msg00637.html
2025-01-08 19:33:37 -05:00
b9eb662334 feat(vertico): allow affixes to be escaped
So we can search for "modulep\!" without it triggering the ! dispatcher.
2024-09-13 23:07:14 -04:00
4fcf332749 refactor: generalize fd/ripgrep vars & options
I intend to eventually replace projectile with project.el, so these
doom-projectile-* variables need to be generalized, starting with the
fd/ripgrep executable paths.

ALong with that, this refactors Doom's projectile-generic-command to
lean more on built-in fd support in projectile, where possible (fewer
wheels reinvented).

Ref: doomemacs/core#1
2024-08-09 21:03:37 -04:00
1584f8a61e fix(vertico): use consult-fd only with new enough fd 2024-01-27 23:34:56 +02:00
60e22fd2eb refactor(vertico): use consult-fd
Close: #7458
Co-authored-by: LemonBreezes <look@strawberrytea.xyz>
2024-01-27 23:34:56 +02:00
acb5af177b fix(vertico): don't shell-quote consult-ripgrep-args
We were using `shell-quote-argument`, which is meant for passing file
names, strings and so on, not command-line arguments. For example,
`(shell-quote-argument "--foo=bar")` yields "--foo\\=bar", which is
obviiously invalid unless we're trying to pass an option named '--foo\'.

At any rate, there is no quoting/escaping for shells in the default
value of `consult-ripgrep-args`, so it doesn't look like this is
something we need to do.
2024-01-25 19:59:13 -05:00
ae451ff754 docs(vertico): mention :args option in docstring 2024-01-25 19:59:13 -05:00
03d692f129 fix(vertico): embark open in new workspace action 2023-12-08 15:11:45 -05:00
890f200b41 feat(vertico): bind C-h/C-l to enter-or-preview/move up
Close: #7001
Ref: #6853
2023-03-22 17:57:38 -04:00
e5dbd4e8b1 bump: :completion vertico compat
iyefrat/all-the-icons-completion@4da28584a1 -> iyefrat/all-the-icons-completion@b08f053cee
minad/consult@ffaaf6da90 -> minad/consult@052399ed05
minad/marginalia@ccf573e214 -> minad/marginalia@2633b2dee2
minad/vertico@6f22ff1298 -> minad/vertico@b6b8420d29
oantolin/embark@5497a19eef -> oantolin/embark@3ffb27a833
oantolin/orderless@d09aab3795 -> oantolin/orderless@e678402671
tumashu/vertico-posframe@f57b170b43 -> tumashu/vertico-posframe@7da6d648ff
emacs-compat/compat@38280a7b54 -> emacs-compat/compat@7775c31857

---

consult--grep added support for searching in multiple directories, so we
can drop the advice in `doom--help-search`. The other changes just adapt
to upstream API changes.
2023-03-22 16:35:07 -04:00
b13c058429 fix(vertico): update +vertico/consult-fd to new builder format 2023-02-17 12:34:58 -05:00
3c99e9f8ab bump: :completion vertico compat
emacs-straight/compat@cc1924fd8b -> emacs-straight/compat@7ca7d300d1
minad/consult@e4e2af1a2d -> minad/consult@16b2dc5e34
minad/marginalia@c68164c564 -> minad/marginalia@c1365bf0c7
minad/vertico@801ad3143d -> minad/vertico@bedd146c3f
oantolin/embark@09da327d43 -> oantolin/embark@629cce948c
oantolin/orderless@004cee6b8e -> oantolin/orderless@847694e78c
tumashu/vertico-posframe@61a88aec07 -> tumashu/vertico-posframe@a3d0802d7b

---

convert consult--ripgrep-builder instance to  consult--ripgrep-make-builder
2023-01-01 21:55:13 -05:00
ba859fcfc0 nit(vertico): add missing function docstring 2022-09-07 00:22:25 +02:00
3694969dd4 nit(vertico): typo in docstring 2022-09-07 00:22:25 +02:00
ad6a3d0f33 refactor: deprecate featurep! for modulep!
featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.

featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.
2022-08-14 20:43:35 +02:00
40ca1a799f fix(vertico): +vertico/consult-fd
`consult--regexp-compiler` now has 3 arguments

Ref: minad/consult@f0e696dd0d
2022-07-24 00:08:45 +02:00
cbc3c0860e fix(vertico): unrecognized keyword :function error
Due to upstream change to consult-async-split-styles-alist.

Ref: minad/consult@dbe48621f3
2022-06-29 18:14:21 +02:00
9d1df5f298 nit: minor refactors & comment/docstring revisions 2022-06-21 14:40:15 +02:00
c13b59395c bump: :completion vertico
minad/consult@d30213aa20 -> minad/consult@822928a860
minad/marginalia@dbc37b373e -> minad/marginalia@26f2bd9ee7
minad/vertico@46e8e05650 -> minad/vertico@cc5f5421c6
oantolin/embark@2890e535f5 -> oantolin/embark@d88478b45f
oantolin/orderless@8f64537f55 -> oantolin/orderless@75eeae2197

- Remove everything related to `consult-completing-read-multiple` since
the function has been deprecated upstream due to implementation issues

Ref: minad/consult#567
Close: #6352
2022-05-26 01:18:02 +03:00
c9665f733b fix(vertico): update +vertico-workspace-buffer-state to new api
also adapt upstream improvements
2022-04-12 02:32:20 +02:00
7121e993ca bump: :completion
PythonNut/helm-flx@6640fac5cb -> PythonNut/helm-flx@27dd9e3ce3
abo-abo/swiper@c97ea72285 -> abo-abo/swiper@764e0d35ba
company-mode/company-mode@073aef72dd -> company-mode/company-mode@1005540b1c
emacs-helm/helm@5b17313011 -> emacs-helm/helm@1003539c2e
minad/consult-flycheck@0ad7e8ff15 -> minad/consult-flycheck@9b40f136c0
minad/consult@473e6585c5 -> minad/consult@36b8bc7065
minad/marginalia@e63d27e6fb -> minad/marginalia@a514c024ac
minad/vertico@a92b1e47ff -> minad/vertico@7ec0f0c076
oantolin/embark@06d5caafd5 -> oantolin/embark@2890e535f5
oantolin/orderless@f2c78c4a60 -> oantolin/orderless@8f64537f55
2022-04-08 02:52:54 +02:00
d54462fe6d fix(vertico): vertico-resume to vertico-repeat. 2022-04-01 18:57:41 +02:00
0e802f4653 bump: :completion
abo-abo/swiper@1c6b3da377 -> abo-abo/swiper@c97ea72285
company-mode/company-mode@8b58e5895c -> company-mode/company-mode@073aef72dd
emacs-helm/helm@a246a9b278 -> emacs-helm/helm@5b17313011
ericdanan/counsel-projectile@e30150792a -> ericdanan/counsel-projectile@40d1e1d4bb
minad/consult@2106eee75f -> minad/consult@473e6585c5
minad/marginalia@e9540a7b80 -> minad/marginalia@e63d27e6fb
minad/vertico@509ca602c7 -> minad/vertico@a92b1e47ff
oantolin/embark@56e28c23d5 -> oantolin/embark@06d5caafd5
oantolin/orderless@ce462a63e3 -> oantolin/orderless@f2c78c4a60
raxod502/prescient.el@292ac9fe35 -> raxod502/prescient.el@c5295a9eec
tumashu/ivy-posframe@5d9420252c -> tumashu/ivy-posframe@533a8e368f
tumashu/posframe@3b1dc400d2 -> tumashu/posframe@c91d4d53fa
2022-03-30 17:32:47 +02:00
614aefc339 tweak(vertico): ignore svn and hg dirs in file search 2022-03-19 16:38:00 +01:00
89deac190d fix(vertico): signature for +vertico/switch-workspace-buffer
An unused argument I forgot to remove.

Amend: 81629dc2ad
2022-02-17 21:17:39 +01:00
81629dc2ad feat(vertico): switch to buffer's workspace
When selecting a buffer in another workspace with
+vertico/switch-workspace-buffer, that workspace will be switched to,
instead of opening the buffer in the current workspace.
2022-02-17 21:14:27 +01:00
72c7d07fb4 fix(vertico): 9 workspace limit in switch-workspace-buffer
+vertico/switch-workspace-buffer was hardcoded to only list buffers from
the first 9 workspaces. This removes that limit.

Minor catch: workspaces beyond 9 will use lower case a-z as narrowing
keys, followed by upper case A-Z. There will not be any valid narrowing
keys beyond 61 workspaces -- but who in the world would have that many?
2022-02-17 21:14:24 +01:00
dacf38bad3 fix(vertico): let C-c C-e run existing embark-after-export-hook
Previously, +vertico/embark-export-write doesn't let embark execute
other added hooks in embark-after-export-hook.

Add the edit command at the end of the list because other hooks may
assume that the buffer isn't yet editable.
2022-01-30 20:42:05 +01:00
4f34635e04 refactor!(vertico): crm keybindings behaviour
BREAKING CHANGE: This commit changes the behaviour of the TAB and RET
keys in a consult-completing read multiple session, in order to make
them more intuitive. The behaviour is now:

- TAB: (unchanged) always select or deselect the current candidate, and
  if the candidate is selected, move the index to the next one (this
  allows for pressing TAB repeatedly to select multiple subsequent
  candidates).

- RET: If no candidates have been selected, select the current candidate
  and exit the completion session. If some have been selected, disregard
  the current candidate and exit.

- S-TAB: (new) like TAB, but the keeps the input.
2022-01-13 23:16:03 +02:00
39ed5eb9ec bump: :completion vertico
minad/consult-flycheck@92b259e6a8 -> minad/consult-flycheck@0ad7e8ff15
minad/consult@57dc1adfdc -> minad/consult@85008702de
minad/marginalia@678b6528f3 -> minad/marginalia@2fb2787bc3
minad/vertico@75f33e3620 -> minad/vertico@eedcb84786
oantolin/embark@5b34b2b603 -> oantolin/embark@725794f013
oantolin/orderless@62f71c34ba -> oantolin/orderless@1ccf74ffdb

Remove +vertico-embark-vertico-indicator as it has been implemented upstream
2021-12-13 01:18:11 +01:00
daf8d278d0 fix(lib): doom/help-search
Due to malformed ripgrep command (no whitespace between "." and extra
arguments).

Fix: #5758
2021-11-20 00:55:22 +01:00
c8199c5c20 fix(vertico): remove noise from which-key indicator
Embark adds easier prefix-argument and digit-argument insertion in
embark-act, but these clog up the space in the which-key indicator

Also update the embark-become test to the new target format.
2021-11-19 00:29:51 +02:00
6e629c1c53 refactor(vertico): move defadvice!'s to config.el
The vast majority of Doom modules have their defadvice! statements in
their config.el files, and not their autoloads. Since these don't need
to be autoloaded to function, we move them for better consistency.
2021-11-18 22:41:40 +02:00
04e96c6faf bump: :completion vertico
iyefrat/all-the-icons-completion@9650041854 -> iyefrat/all-the-icons-completion@a0f34d68cc
minad/consult@dc6e455861 -> minad/consult@166e3b03c3
minad/marginalia@cb1d3ba604 -> minad/marginalia@fbd2f378f5
minad/vertico@0df75c0bbc -> minad/vertico@cd3c400aac
oantolin/embark@1492aefc00 -> oantolin/embark@8a0b80c6e6

Add --null to consult-ripgrep-args to comply with upstream changes to
filename detection.

Update +vertico-embark-which-key-indicator.

Fix #5494
Fix #5547
2021-10-10 10:46:14 +03:00
34f76c8a75 fix(vertico): +vertico/switch-workspace-buffer
- fix a paren error in the function that caused the buffers to be sorted
  alphabetically and not by recency
- refactor the workspace buffer sources to use consult--buffer-query,
  that way we get niceties like the current buffer being last

Fix #5366
2021-09-23 14:55:58 +02:00
dda5f558b2 fix(vertico): adapt to targets changing to plists
embark targets changed internally to plists a while back. This didn't
really seem to break anything but it's best to be up to date with the
upstream representation.
2021-09-23 14:55:58 +02:00
a612220369 refactor!(vertico): evil minibuffer keybindings
BREAKING CHANGE: remove +vertico/(next|previous)-candidate-preview.

BREAKING CHANGE: Move vertico-(next|previous)-group to C-M-j/k now that

C-S-j/k now default back to scrolling up and down pages.

Update docs to reflect these changes.
2021-09-15 01:41:37 +03:00
9241a4d709 refactor(vertico): file completion backspace
Switch from the homemade +vertico/backward-updir to the upstream
vertico-directory-delete-char. The former has the nice feature of
traversing up abbreviated paths, but this comes at the cost of not being
able to fully erase the path (since the buck stops at /), and
unintentional directory moving in commands such as +vertico/find-file-in
which causes issues. Overall this minor convenience is not worth it, so
the vertico-directory-delete-char behaviour of just deleting up to the
previous / is preferred instead.
2021-09-15 01:03:11 +03:00
9d44b3510a fix(vertico): +vertico/jump-list requires consult 2021-09-15 01:03:11 +03:00
f536103af6 fix(vertico): package target finder
now returns nil instead of erroring out when it can't find a paren in
the buffer

Co-authored-by: Leo Okawa Ericson <git@relevant-information.com>
2021-09-15 01:03:11 +03:00
1f3ac1eb77 nit(vertico): fix whitespace 2021-09-15 01:03:11 +03:00
934ad07f23 feat(vertico): add magit-status embark action 2021-09-15 01:03:11 +03:00
fc163b16c9 feat(vertico): use basic completion for remotes
Close: #5313

Co-authored-by: Stefan Lendl <ste.lendl@gmail.com>
2021-09-15 01:03:11 +03:00
2c431aae0e fix(vertico): +vertico/find-file-in...
allow the creation of new files if the input doesn't match any existing
ones.
2021-09-14 20:44:55 +03:00
0a69ca957a refactor(vertico): rename which key indicator
rename +vertico/embark-which-key-indicator to
+vertico-embark-which-key-indicator, since it's not interactive
2021-09-14 20:38:40 +03:00
26014435b2 feat(vertico): colorize vertico candidate on act 2021-09-14 20:38:40 +03:00
940f66fa89 bump: :completion vertico
iyefrat/all-the-icons-completion@d1d4b2f0df -> iyefrat/all-the-icons-completion@9650041854
minad/consult@69bbd213dc -> minad/consult@105a1ac501
minad/marginalia@1123544536 -> minad/marginalia@c6ca58bea8
minad/vertico@9de6709cdd -> minad/vertico@81a4b35f8d
oantolin/embark@1a7e6b5561 -> oantolin/embark@19145d5a33
oantolin/orderless@1e84120a28 -> oantolin/orderless@1a7011ac9c

- Adapt consult async commands to new consult-x-args format instead of
  consult-x-command.
- Change regepx in +vertico-file-search to emacs instead of pcre,
  because consult switched to using only emacs regexps
- Move to new embark-indicators variable, and replace
  embark-mixed-indicator with +vertico/embark-which-key-indicator to be
  compatible with future changes
- Adapt Doom's optional usage of fd to new consult command format
2021-09-14 20:38:40 +03:00
265e19a405 fix(vertico): +vertico/jump-list failing to jump
Prior to this fix this command would error out because of incorrect
expectations wrt consult--read's return value.
2021-08-21 03:29:13 -04:00