awesome-emacs/doomemacs
1
0
Fork 0
mirror of https://github.com/doomemacs/doomemacs synced 2025-08-03 12:27:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

dev(ci): fix commit linter receiving empty summary

Browse Source 
split-string is not side-effect free. It changes the match data (it uses
regexp to split strings).
This commit is contained in:
Henrik Lissner
2021-09-30 13:00:08 +02:00
parent fb34b5e24c
commit e9b13393eb
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
core/cli/ci.el
View File

@ -264,8 +264,8 @@
(when (looking-at "^\\([a-zA-Z0-9_-]+\\)\\(!?\\)\\(?:(\\([^)]+\\))\\)?: \\([^\n]+\\)") (when (looking-at "^\\([a-zA-Z0-9_-]+\\)\\(!?\\)\\(?:(\\([^)]+\\))\\)?: \\([^\n]+\\)")
(setq type (intern (match-string 1)) (setq type (intern (match-string 1))
bang (equal (match-string 2) "!") bang (equal (match-string 2) "!")
scopes (ignore-errors (split-string (match-string 3) ",")) summary (match-string 4)
summary (match-string 4))))) scopes (ignore-errors (split-string (match-string 3) ","))))))
(unless (string-match-p "^\\(?:\\(?:fixup\\|squash\\)!\\|FIXUP\\|WIP\\) " subject) (unless (string-match-p "^\\(?:\\(?:fixup\\|squash\\)!\\|FIXUP\\|WIP\\) " subject)
(dolist (fn doom-cli-commit-rules) (dolist (fn doom-cli-commit-rules)
(pcase (funcall fn (pcase (funcall fn