awesome-emacs/doomemacs
1
0
Fork 0
mirror of https://github.com/doomemacs/doomemacs synced 2025-08-13 13:13:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix(eshell): remove fish executable advice

Browse Source 
Ref: LemonBreezes/emacs-fish-completion@99f0672c20
This commit is contained in:
StrawberryTea
2024-02-01 17:47:20 -06:00
committed by GitHub
parent ddca307b39
commit d1d0a7e258
1 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
modules/term/eshell/config.el
View File

@@ -244,12 +244,5 @@ Emacs versions < 29."
(use-package! fish-completion
:unless IS-WINDOWS
:hook (eshell-mode . fish-completion-mode)
:init (setq fish-completion-fallback-on-bash-p t)
:config
;; HACK Even with `fish-completion-fallback-on-bash-p' non-nil,
;; `fish-completion--list-completions-with-desc' will throw an error if
;; fish isn't installed (and so, will fail to fall back to bash), so we
;; advise it to fail silently.
(defadvice! +eshell--fallback-to-bash-a (&rest _)
:before-until #'fish-completion--list-completions-with-desc
(unless (executable-find "fish") "")))
:init (setq fish-completion-fallback-on-bash-p t
fish-completion-inhibit-missing-fish-command-warning t))