refactor: deprecate featurep! for modulep!

featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.

featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.

modules/lang/zig/config.el

@@ -12,13 +12,13 @@
   :config
   (setq zig-format-on-save nil) ; rely on :editor format instead
 
-  (when (featurep! +lsp)
+  (when (modulep! +lsp)
     (add-hook 'zig-mode-local-vars-hook #'lsp! 'append))
 
-  (when (featurep! +tree-sitter)
+  (when (modulep! +tree-sitter)
     (add-hook 'zig-mode-local-vars-hook #'tree-sitter! 'append))
 
-  (when (featurep! :checkers syntax)
+  (when (modulep! :checkers syntax)
     (flycheck-define-checker zig
       "A zig syntax checker using zig's `ast-check` command."
       :command ("zig" "ast-check" (eval (buffer-file-name)))

modules/lang/zig/doctor.el

@@ -1,17 +1,17 @@
 ;; -*- lexical-binding: t; no-byte-compile: t; -*-
 ;;; lang/zig/doctor.el
 
-(assert! (or (not (featurep! +lsp))
-             (featurep! :tools lsp))
+(assert! (or (not (modulep! +lsp))
+             (modulep! :tools lsp))
          "This module requires (:tools lsp)")
 
-(assert! (or (not (featurep! +tree-sitter))
-             (featurep! :tools tree-sitter))
+(assert! (or (not (modulep! +tree-sitter))
+             (modulep! :tools tree-sitter))
          "This module requires (:tools tree-sitter)")
 
 (unless (executable-find "zig")
   (warn! "Couldn't find zig binary"))
 
-(when (featurep! +lsp)
+(when (modulep! +lsp)
   (unless (executable-find "zls")
     (warn! "Couldn't find zls binary")))