refactor: deprecate featurep! for modulep!

featurep! will be renamed modulep! in the future, so it's been
deprecated. They have identical interfaces, and can be replaced without
issue.

featurep! was never quite the right name for this macro. It implied that
it had some connection to featurep, which it doesn't (only that it was
similar in purpose; still, Doom modules are not features). To undo such
implications and be consistent with its namespace (and since we're
heading into a storm of breaking changes with the v3 release anyway),
now was the best opportunity to begin the transition.

modules/lang/julia/config.el

@@ -5,10 +5,10 @@
   :config
   (set-repl-handler! 'julia-mode #'+julia/open-repl)
 
-  (when (featurep! +lsp)
+  (when (modulep! +lsp)
     (add-hook 'julia-mode-local-vars-hook #'lsp! 'append))
 
-  (when (featurep! +tree-sitter)
+  (when (modulep! +tree-sitter)
     (add-hook 'julia-mode-local-vars-hook #'tree-sitter! 'append))
 
   ;; Borrow matlab.el's fontification of math operators. From
@@ -54,7 +54,7 @@
   :config
   (set-popup-rule! "^\\*julia.*\\*$" :ttl nil)
 
-  (when (featurep! :ui workspaces)
+  (when (modulep! :ui workspaces)
     (defadvice! +julia--namespace-repl-buffer-to-workspace-a (&optional executable-key suffix)
       "Name for a Julia REPL inferior buffer. Uses workspace name for doom emacs"
       :override #'julia-repl--inferior-buffer-name
@@ -72,8 +72,8 @@
 
 
 (use-package! lsp-julia
-  :when (featurep! +lsp)
-  :unless (featurep! :tools lsp +eglot)
+  :when (modulep! +lsp)
+  :unless (modulep! :tools lsp +eglot)
   :after lsp-mode
   :preface (setq lsp-julia-default-environment nil)
   :init
@@ -86,8 +86,8 @@
 
 
 (use-package! eglot-jl
-  :when (featurep! +lsp)
-  :when (featurep! :tools lsp +eglot)
+  :when (modulep! +lsp)
+  :when (modulep! :tools lsp +eglot)
   :after eglot
   :preface
   ;; Prevent auto-install of LanguageServer.jl

modules/lang/julia/doctor.el

@@ -1,14 +1,14 @@
 ;;; lang/julia/doctor.el -*- lexical-binding: t; -*-
 
-(assert! (or (not (featurep! +lsp))
-             (featurep! :tools lsp))
+(assert! (or (not (modulep! +lsp))
+             (modulep! :tools lsp))
          "This module requires (:tools lsp)")
 
-(assert! (or (not (featurep! +tree-sitter))
-             (featurep! :tools tree-sitter))
+(assert! (or (not (modulep! +tree-sitter))
+             (modulep! :tools tree-sitter))
          "This module requires (:tools tree-sitter)")
 
-(when (featurep! +lsp)
+(when (modulep! +lsp)
   (let ((args
          (cond ((require 'eglot-jl nil t)
                 `(,eglot-jl-julia-command

modules/lang/julia/packages.el

@@ -4,7 +4,7 @@
 (package! julia-mode :pin "47f43f7d839019cac3ba6559d93b29487ca118cb")
 (package! julia-repl :pin "6c1d63511fb2b3b3f2e342eff6a375d78be6c12c")
 
-(when (featurep! +lsp)
-  (if (featurep! :tools lsp +eglot)
+(when (modulep! +lsp)
+  (if (modulep! :tools lsp +eglot)
       (package! eglot-jl :pin "2e35cf9768d97a0429a72deddbe30d6d7722d454")
     (package! lsp-julia :pin "d6688bb131ff4a5a0201f6d3826ef0b018265389")))