def-advice!->defadvice! & conform to new advice conventions

This commit does two things:

- Renames def-advice! to defadvice!, in the spirit of naming convenience
  macros after the function/macro they enhance or replace.
- Correct the names of advice functions to indicate visibility and
  intent. A public advice function like doom-set-jump-a is meant to be
  used elsewhere. A private one like +dired--cleanup-header-line-a
  shouldn't -- it likely won't work anywhere but the function(s) it was
  made to advise.

modules/tools/pass/config.el

@@ -14,7 +14,7 @@
 (setq password-store-password-length 12)
 
 ;; Fix hard-coded password-store location; respect PASSWORD_STORE_DIR envvar
-(def-advice! +pass-read-entry-a (entry)
+(defadvice! +pass--respect-pass-dir-envvar-a (entry)
   "Return a string with the file content of ENTRY."
   :override #'auth-source-pass--read-entry
   (with-temp-buffer