def-advice!->defadvice! & conform to new advice conventions

This commit does two things:

- Renames def-advice! to defadvice!, in the spirit of naming convenience
  macros after the function/macro they enhance or replace.
- Correct the names of advice functions to indicate visibility and
  intent. A public advice function like doom-set-jump-a is meant to be
  used elsewhere. A private one like +dired--cleanup-header-line-a
  shouldn't -- it likely won't work anywhere but the function(s) it was
  made to advise.

modules/completion/ido/config.el

@@ -28,7 +28,7 @@
                 (insert "~/")
               (call-interactively #'self-insert-command))))
 
-  (def-advice! +ido-sort-mtime-a ()
+  (defadvice! +ido--sort-mtime-a ()
     "Sort ido filelist by mtime instead of alphabetically."
     :override #'ido-sort-mtime
     (setq ido-temp-list