awesome-emacs/doomemacs
1
0
Fork 0
mirror of https://github.com/doomemacs/doomemacs synced 2025-09-16 15:56:52 -05:00
Code Issues Packages Projects Releases Wiki Activity

def-advice!->defadvice! & conform to new advice conventions

Browse Source 
This commit does two things:

- Renames def-advice! to defadvice!, in the spirit of naming convenience
  macros after the function/macro they enhance or replace.
- Correct the names of advice functions to indicate visibility and
  intent. A public advice function like doom-set-jump-a is meant to be
  used elsewhere. A private one like +dired--cleanup-header-line-a
  shouldn't -- it likely won't work anywhere but the function(s) it was
  made to advise.
This commit is contained in:
Henrik Lissner
2019-07-23 17:24:56 +02:00
parent 8aa7772e4e
commit 82ae3a73f3
43 changed files with 126 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
modules/completion/helm/config.el
View File

@@ -83,7 +83,7 @@ be negative.")
:init
(when (and EMACS26+ (featurep! +childframe))
(setq helm-display-function #'+helm-posframe-display-fn)
(def-advice! +helm--fix-get-font-height-a (orig-fn position)
(defadvice! +helm--fix-get-font-height-a (orig-fn position)
"Fix \"Specified window is not displaying the current buffer\" error."
:around #'posframe--get-font-height
(ignore-errors (funcall orig-fn position))))