def-advice!->defadvice! & conform to new advice conventions

This commit does two things:

- Renames def-advice! to defadvice!, in the spirit of naming convenience
  macros after the function/macro they enhance or replace.
- Correct the names of advice functions to indicate visibility and
  intent. A public advice function like doom-set-jump-a is meant to be
  used elsewhere. A private one like +dired--cleanup-header-line-a
  shouldn't -- it likely won't work anywhere but the function(s) it was
  made to advise.

core/core-projects.el

@@ -118,7 +118,7 @@ c) are not valid projectile projects."
     ;; fix breakage on windows in git projects
     (unless (executable-find "tr")
       (setq projectile-git-submodule-command nil))))
-
+
   (defadvice! doom--projectile-cache-timers-a ()
     "Persist `projectile-projects-cache-time' across sessions, so that
 `projectile-files-cache-expire' checks won't reset when restarting Emacs."
@@ -128,7 +128,7 @@ c) are not valid projectile projects."
   (when (file-readable-p doom-projectile-cache-timer-file)
     (setq projectile-projects-cache-time
           (projectile-unserialize doom-projectile-cache-timer-file)))
-
+
   (defadvice! doom--projectile-default-generic-command-a (orig-fn &rest args)
     "If projectile can't tell what kind of project you're in, it issues an error
 when using many of projectile's command, e.g. `projectile-compile-command',
@@ -142,7 +142,7 @@ the command instead."
 
   ;; Projectile root-searching functions can cause an infinite loop on TRAMP
   ;; connections, so disable them.
-  ;; TODO Is this still necessary?
+  ;; TODO Is this still necessary?
   (defadvice! doom--projectile-locate-dominating-file-a (orig-fn file name)
     "Don't traverse the file system if on a remote connection."
     :around #'projectile-locate-dominating-file