refactor!: remove highlight-numbers

BREAKING CHANGE: Numerics will no longer be syntax highlighted in major
modes that don't already have their own (or provided by tree-sitter). No
substitute will be provided because it's trivial for the user to install
themselves.

Ref: https://github.com/orgs/doomemacs/projects/5/views/1?pane=issue&itemId=117610783

modules/completion/ivy/autoload/ivy.el

@@ -56,8 +56,8 @@ Buffers that are considered unreal (see `doom-real-buffer-p') are dimmed with
             (prin1-to-string val))
            ((stringp val)
             (propertize (format "%S" val) 'face 'font-lock-string-face))
-           ((numberp val)
-            (propertize (format "%s" val) 'face 'highlight-numbers-number))
+           ((and (numberp val) (facep 'font-lock-number-face)) ; introduced in 29.1+
+            (propertize (format "%s" val) 'face 'font-lock-number-face))
            ((format "%s" val)))
      t)))
 

modules/lang/elixir/config.el

@@ -46,12 +46,7 @@
       (add-to-list 'lsp-file-watch-ignored-directories "[/\\\\]_build\\'")))
 
   (when (modulep! +tree-sitter)
-    (add-hook 'elixir-mode-local-vars-hook #'tree-sitter! 'append))
-
-  (after! highlight-numbers
-    (puthash 'elixir-mode
-             "\\_<-?[[:digit:]]+\\(?:_[[:digit:]]\\{3\\}\\)*\\_>"
-             highlight-numbers-modelist)))
+    (add-hook 'elixir-mode-local-vars-hook #'tree-sitter! 'append)))
 
 
 (use-package! flycheck-credo

modules/lang/emacs-lisp/config.el

@@ -166,8 +166,6 @@ See `+emacs-lisp-non-package-mode' for details.")
         (append '(("\\(^\\*\\*\\*[^*]+\\*\\*\\*\\)\\(.*$\\)"
                    (1 font-lock-comment-face)
                    (2 font-lock-constant-face)))
-                (when (require 'highlight-numbers nil t)
-                  (highlight-numbers--get-regexp-for-mode 'emacs-lisp-mode))
                 (cl-loop for (matcher . match-highlights)
                          in (append lisp-el-font-lock-keywords-2
                                     lisp-cl-font-lock-keywords-2)