From 59c6b8e61403d425b10dfacdac9fc3f3c53a41a1 Mon Sep 17 00:00:00 2001
From: Henrik Lissner <git@henrik.io>
Date: Sun, 29 Jun 2025 17:34:26 +0200
Subject: [PATCH] refactor!(ruby): remove rubocop

BREAKING CHANGE: This removes rubocop from the ruby module in lieu of
LSP clients.

Ref: https://github.com/orgs/doomemacs/projects/5/views/1?pane=issue&itemId=69411575
---
 modules/lang/ruby/README.org  |  7 ++-----
 modules/lang/ruby/config.el   | 12 ------------
 modules/lang/ruby/packages.el |  3 ---
 3 files changed, 2 insertions(+), 20 deletions(-)

diff --git a/modules/lang/ruby/README.org b/modules/lang/ruby/README.org
index f59ad65d8..585826104 100644
--- a/modules/lang/ruby/README.org
+++ b/modules/lang/ruby/README.org
@@ -38,7 +38,6 @@ client (recommended: [[https://github.com/Shopify/ruby-lsp][ruby-lsp]] or [[http
 - [[doom-package:rake]]
 - [[doom-package:rbenv]] if [[doom-module:+rbenv]]
 - [[doom-package:rspec-mode]]
-- [[doom-package:rubocop]]
 - [[doom-package:rvm]] if [[doom-module:+rvm]]
 - if [[doom-module:+rails]]
   - [[doom-package:inflections]]
@@ -55,16 +54,14 @@ client (recommended: [[https://github.com/Shopify/ruby-lsp][ruby-lsp]] or [[http
 * Installation
 [[id:01cffea4-3329-45e2-a892-95a384ab2338][Enable this module in your ~doom!~ block.]]
 
-This module requires Ruby and the Rubocop gem. It is recommended you install
-both with some version manager (RVM or Rbenv).
+This module requires Ruby. It is recommended you install it with some version
+manager (e.g. RVM or Rbenv).
 
 These guides will help you install Ruby:
 - [[https://gorails.com/setup/ubuntu/18.04][Ubuntu]]
 - [[https://gorails.com/setup/osx/10.15-catalina][MacOS]]
 - [[https://gorails.com/setup/windows/10][Windows]]
 
-Then run ~$ gem install rubocop~ to install rubocop.
-
 ** Formatter
 Formatting is handled using the [[doom-module::editor format]] module via [[https://prettier.io/docs/en/install.html][prettier]].
 
diff --git a/modules/lang/ruby/config.el b/modules/lang/ruby/config.el
index 1420363c5..4f0a7c501 100644
--- a/modules/lang/ruby/config.el
+++ b/modules/lang/ruby/config.el
@@ -43,18 +43,6 @@
   :hook ruby-mode)
 
 
-(use-package! rubocop
-  :hook (ruby-mode . rubocop-mode)
-  :config
-  (set-popup-rule! "^\\*RuboCop" :select t)
-  (map! :localleader
-        :map rubocop-mode-map
-        "f" #'rubocop-check-current-file
-        "F" #'rubocop-autocorrect-current-file
-        "p" #'rubocop-check-project
-        "P" #'rubocop-autocorrect-project))
-
-
 (use-package! ruby-json-to-hash
   :defer t
   :init
diff --git a/modules/lang/ruby/packages.el b/modules/lang/ruby/packages.el
index 7bd2d590e..c96504ccc 100644
--- a/modules/lang/ruby/packages.el
+++ b/modules/lang/ruby/packages.el
@@ -10,9 +10,6 @@
 (when (modulep! :completion company)
   (package! company-inf-ruby :pin "fe3e4863bc971fbb81edad447efad5795ead1b17"))
 
-;; Programming environment
-(package! rubocop :pin "f5fd18aa810c3d3269188cbbd731ddc09006f8f5")
-
 ;; Project tools
 (package! bundler :pin "43efb6be4ed118b06d787ce7fbcffd68a31732a7")
 (package! rake :pin "452ea0caca33376487103c64177c295ed2960cca")