💥 revise advice naming convention (1/2)

This is first of three big naming convention updates that have been a
long time coming. With 2.1 on the horizon, all the breaking updates will
batched together in preparation for the long haul.

In this commit, we do away with the asterix to communicate that a
function is an advice function, and we replace it with the '-a' suffix.
e.g.

  doom*shut-up -> doom-shut-up-a
  doom*recenter -> doom-recenter-a
  +evil*static-reindent -> +evil--static-reindent-a

The rationale behind this change is:

1. Elisp's own formatting/indenting tools would occasionally struggle
   with | and * (particularly pp and cl-prettyprint). They have no
   problem with / and :, fortunately.
2. External syntax highlighters (like pygmentize, discord markdown or
   github markdown) struggle with it, sometimes refusing to highlight
   code beyond these symbols.
3. * and | are less expressive than - and -- in communicating the
   intended visibility, versatility and stability of a function.
4. It complicated the regexps we must use to search for them.
5. They were arbitrary and over-complicated to begin with, decided
   on haphazardly way back when Doom was simply "my private config".

Anyhow, like how predicate functions have the -p suffix, we'll adopt the
-a suffix for advice functions, -h for hook functions and -fn for
variable functions.

Other noteable changes:
- Replaces advice-{add,remove}! macro with new def-advice!
  macro. The old pair weren't as useful. The new def-advice! saves on a
  lot of space.
- Removed "stage" assertions to make sure you were using the right
  macros in the right place. Turned out to not be necessary, we'll
  employ better checks later.

modules/ui/doom/config.el

@@ -86,10 +86,10 @@
     (set-window-fringes (minibuffer-window) 0 0 nil))
   (add-hook 'solaire-mode-hook #'+doom|disable-fringes-in-minibuffer)
 
-  (defun doom*no-fringes-in-which-key-buffer (&rest _)
-    (+doom|disable-fringes-in-minibuffer)
+  (def-advice! +doom--no-fringes-in-which-key-buffer-a (&rest _)
+    :after 'which-key--show-buffer-side-window
+    (+doom--disable-fringes-in-minibuffer-h)
     (set-window-fringes (get-buffer-window which-key--buffer) 0 0 nil))
-  (advice-add 'which-key--show-buffer-side-window :after #'doom*no-fringes-in-which-key-buffer)
 
   (add-hook! '(minibuffer-setup-hook window-configuration-change-hook)
     #'+doom|disable-fringes-in-minibuffer)

modules/ui/modeline/config.el

@@ -58,10 +58,10 @@
     '(misc-info mu4e github debug fancy-battery " " major-mode process))
 
   ;; Some functions modify the buffer, causing the modeline to show a false
-  ;; modified state, so we try to force them to behave.
-  (defun +modeline*inhibit-modification-hooks (orig-fn &rest args)
-    (with-silent-modifications (apply orig-fn args)))
-  (advice-add #'ws-butler-after-save :around #'+modeline*inhibit-modification-hooks))
+  ;; modified state, so force them to behave.
+  (def-advice! +modeline--inhibit-modification-hooks-a (orig-fn &rest args)
+    :around #'ws-butler-after-save
+    (with-silent-modifications (apply orig-fn args))))
 
 
 ;;

modules/ui/nav-flash/autoload.el

@@ -36,7 +36,7 @@ for `org-follow-link-hook')."
 (defalias '+nav-flash|blink-cursor-maybe #'+nav-flash-blink-cursor-maybe)
 
 ;;;###autoload
-(defalias '+nav-flash*blink-cursor #'+nav-flash-blink-cursor-maybe)
+(defalias '+nav-flash-blink-cursor-a #'+nav-flash-blink-cursor-maybe)
 
 ;;;###autoload
 (defun +nav-flash/blink-cursor (&rest _)

modules/ui/nav-flash/config.el

@@ -21,10 +21,9 @@
   (add-hook 'org-follow-link-hook #'+nav-flash|delayed-blink-cursor)
 
   ;; `saveplace'
-  (advice-add #'save-place-find-file-hook :after #'+nav-flash*blink-cursor)
+  (advice-add #'save-place-find-file-hook :after #'+nav-flash-blink-cursor-a)
 
   ;; `evil'
-  (advice-add #'evil-window-top    :after #'+nav-flash*blink-cursor)
-  (advice-add #'evil-window-middle :after #'+nav-flash*blink-cursor)
-  (advice-add #'evil-window-bottom :after #'+nav-flash*blink-cursor))
-
+  (advice-add #'evil-window-top    :after #'+nav-flash-blink-cursor-a)
+  (advice-add #'evil-window-middle :after #'+nav-flash-blink-cursor-a)
+  (advice-add #'evil-window-bottom :after #'+nav-flash-blink-cursor-a))

modules/ui/neotree/config.el

@@ -50,8 +50,7 @@
       (+neotree*indent-cursor)))
   (add-hook 'neo-enter-hook #'+neotree*fix-cursor)
 
-  (defun +neotree*indent-cursor (&rest _)
+  (def-advice! +neotree--indent-cursor-a (&rest _)
+    :after '(neotree-next-line neotree-previous-line)
     (beginning-of-line)
-    (skip-chars-forward " \t\r"))
-  (advice-add #'neotree-next-line :after #'+neotree*indent-cursor)
-  (advice-add #'neotree-previous-line :after #'+neotree*indent-cursor))
+    (skip-chars-forward " \t\r")))

modules/ui/popup/+hacks.el

@@ -38,11 +38,10 @@
 
 
 ;;;###package company
-(progn
-  (defun +popup*dont-select-me (orig-fn &rest args)
-    (let ((+popup--inhibit-select t))
-      (apply orig-fn args)))
-  (advice-add #'company-show-doc-buffer :around #'+popup*dont-select-me))
+(def-advice! +popup--dont-select-me-a (orig-fn &rest args)
+  :around #'company-show-doc-buffer
+  (let ((+popup--inhibit-select t))
+    (apply orig-fn args)))
 
 
 ;;;###package eshell
@@ -51,21 +50,22 @@
 
   ;; When eshell runs a visual command (see `eshell-visual-commands'), it spawns
   ;; a term buffer to run it in, but where it spawns it is the problem...
-  (defun +popup*eshell-undedicate-popup (orig-fn &rest args)
+  (def-advice! +popup--eshell-undedicate-popup (&rest _)
     "Force spawned term buffer to share with the eshell popup (if necessary)."
+    :before #'eshell-exec-visual
     (when (+popup-window-p)
       (set-window-dedicated-p nil nil)
       (add-transient-hook! #'eshell-query-kill-processes :after
-                           (set-window-dedicated-p nil t)))
-    (apply orig-fn args))
-  (advice-add #'eshell-exec-visual :around #'+popup*eshell-undedicate-popup))
+                           (set-window-dedicated-p nil t)))))
 
 
 ;;;###package evil
 (progn
-  (defun +popup*evil-command-window (hist cmd-key execute-fn)
+  ;; Make evil-mode cooperate with popups
+  (def-advice! +popup--evil-command-window-a (hist cmd-key execute-fn)
     "Monkey patch the evil command window to use `pop-to-buffer' instead of
 `switch-to-buffer', allowing the popup manager to handle it."
+    :override #'evil-command-window
     (when (eq major-mode 'evil-command-window-mode)
       (user-error "Cannot recursively open command line window"))
     (dolist (win (window-list))
@@ -81,9 +81,10 @@
       (evil-command-window-mode)
       (evil-command-window-insert-commands hist)))
 
-  (defun +popup*evil-command-window-execute ()
+  (def-advice! +popup--evil-command-window-execute-a ()
     "Execute the command under the cursor in the appropriate buffer, rather than
 the command buffer."
+    :override #'evil-command-window-execute
     (interactive)
     (let ((result (buffer-substring (line-beginning-position)
                                     (line-end-position)))
@@ -98,10 +99,6 @@ the command buffer."
       (funcall execute-fn result)
       (setq evil-command-window-current-buffer nil)))
 
-  ;; Make evil-mode cooperate with popups
-  (advice-add #'evil-command-window :override #'+popup*evil-command-window)
-  (advice-add #'evil-command-window-execute :override #'+popup*evil-command-window-execute)
-
   ;; Don't mess with popups
   (advice-add #'+evil--window-swap           :around #'+popup*save)
   (advice-add #'evil-window-move-very-bottom :around #'+popup*save)
@@ -153,21 +150,20 @@ the command buffer."
 
 
 ;;;###package helpful
-(progn
-  (defun +popup*helpful-open-in-origin-window (button)
-    "Open links in non-popup, originating window rather than helpful's window."
-    (let ((path (substring-no-properties (button-get button 'path)))
-          enable-local-variables
-          origin)
-      (save-popups!
-       (find-file path)
-       (when-let (pos (get-text-property button 'position
-                                         (marker-buffer button)))
-         (goto-char pos))
-       (setq origin (selected-window))
-       (recenter))
-      (select-window origin)))
-  (advice-add #'helpful--navigate :override #'+popup*helpful-open-in-origin-window))
+(def-advice! +popup--helpful-open-in-origin-window-a (button)
+  "Open links in non-popup, originating window rather than helpful's window."
+  :override #'helpful--navigate
+  (let ((path (substring-no-properties (button-get button 'path)))
+        enable-local-variables
+        origin)
+    (save-popups!
+     (find-file path)
+     (when-let (pos (get-text-property button 'position
+                                       (marker-buffer button)))
+       (goto-char pos))
+     (setq origin (selected-window))
+     (recenter))
+    (select-window origin)))
 
 
 ;;;###package helm
@@ -176,7 +172,8 @@ the command buffer."
   (setq helm-default-display-buffer-functions '(+popup-display-buffer-stacked-side-window))
 
   ;; Fix #897: "cannot open side window" error when TAB-completing file links
-  (defun +popup*hide-org-links-popup (orig-fn &rest args)
+  (def-advice! +popup--helm-hide-org-links-popup-a (orig-fn &rest args)
+    :around #'org-insert-link
     (cl-letf* ((old-org-completing-read (symbol-function 'org-completing-read))
                ((symbol-function 'org-completing-read)
                 (lambda (&rest args)
@@ -192,23 +189,22 @@ the command buffer."
                     (get-buffer-create "*Org Links*"))
                   (apply old-org-completing-read args))))
       (apply orig-fn args)))
-  (advice-add #'org-insert-link :around #'+popup*hide-org-links-popup)
 
   ;; Fix left-over popup window when closing persistent help for `helm-M-x'
-  (defun +popup*helm-elisp--persistent-help (candidate _fun &optional _name)
+  (def-advice! +popup--helm-elisp--persistent-help-a (candidate _fun &optional _name)
+    :before #'helm-elisp--persistent-help
     (let (win)
       (when (and (helm-attr 'help-running-p)
                  (string= candidate (helm-attr 'help-current-symbol))
                  (setq win (get-buffer-window (get-buffer (help-buffer)))))
         (delete-window win))))
-  (advice-add #'helm-elisp--persistent-help :before #'+popup*helm-elisp--persistent-help)
 
   ;; `helm-ag'
-  (defun +helm*pop-to-buffer (orig-fn &rest args)
+  (def-advice! +popup--helm-pop-to-buffer-a (orig-fn &rest args)
+    :around #'helm-ag--edit
     (pop-to-buffer
      (save-window-excursion (apply orig-fn args)
-                            (current-buffer))))
-  (advice-add #'helm-ag--edit :around #'+helm*pop-to-buffer))
+                            (current-buffer)))))
 
 
 ;;;###package ibuffer
@@ -216,11 +212,11 @@ the command buffer."
 
 
 ;;;###package Info
-(defun +popup*switch-to-info-window (&rest _)
+(def-advice! +popup--switch-to-info-window-a (&rest _)
+  :after #'info-lookup-symbol
   (when-let (win (get-buffer-window "*info*"))
     (when (+popup-window-p win)
       (select-window win))))
-(advice-add #'info-lookup-symbol :after #'+popup*switch-to-info-window)
 
 
 ;;;###package multi-term
@@ -235,26 +231,26 @@ the command buffer."
 
 ;;;###package org
 (after! org
-  (defvar +popup--disable-internal nil)
   ;; Org has a scorched-earth window management policy I'm not fond of. i.e. it
   ;; kills all other windows just so it can monopolize the frame. No thanks. We
   ;; can do better ourselves.
-  (defun +popup*suppress-delete-other-windows (orig-fn &rest args)
+  (def-advice! +popup-suppress-delete-other-windows-a (orig-fn &rest args)
+    :around '(org-add-log-note
+              org-capture-place-template
+              org-export--dispatch-ui
+              org-agenda-get-restriction-and-command
+              org-fast-tag-selection)
     (if +popup-mode
         (cl-letf (((symbol-function 'delete-other-windows)
                    (symbol-function 'ignore)))
           (apply orig-fn args))
       (apply orig-fn args)))
-  (advice-add #'org-add-log-note :around #'+popup*suppress-delete-other-windows)
-  (advice-add #'org-capture-place-template :around #'+popup*suppress-delete-other-windows)
-  (advice-add #'org-export--dispatch-ui :around #'+popup*suppress-delete-other-windows)
-  (advice-add #'org-agenda-get-restriction-and-command :around #'+popup*suppress-delete-other-windows)
-  (advice-add #'org-fast-tag-selection :around #'+popup*suppress-delete-other-windows)
 
-  (defun +popup*fix-tags-window (orig-fn &rest args)
+  (def-advice! +popup--org-fix-tags-window-a (orig-fn &rest args)
     "Hides the mode-line in *Org tags* buffer so you can actually see its
 content and displays it in a side window without deleting all other windows.
 Ugh, such an ugly hack."
+    :around #'org-fast-tag-selection
     (if +popup-mode
         (cl-letf* ((old-fit-buffer-fn (symbol-function 'org-fit-window-to-buffer))
                    ((symbol-function 'org-fit-window-to-buffer)
@@ -268,31 +264,31 @@ Ugh, such an ugly hack."
                       (funcall old-fit-buffer-fn window max-height min-height shrink-only))))
           (apply orig-fn args))
       (apply orig-fn args)))
-  (advice-add #'org-fast-tag-selection :around #'+popup*fix-tags-window)
 
-  (defun +popup*org-src-pop-to-buffer (orig-fn buffer context)
+  (def-advice! +popup-org-src-pop-to-buffer-a (orig-fn buffer context)
     "Hand off the src-block window to the popup system by using `display-buffer'
 instead of switch-to-buffer-*."
+    :around #'org-src-switch-to-buffer
     (if (and (eq org-src-window-setup 'popup-window)
              +popup-mode)
         (pop-to-buffer buffer)
       (funcall orig-fn buffer context)))
-  (advice-add #'org-src-switch-to-buffer :around #'+popup*org-src-pop-to-buffer)
   (setq org-src-window-setup 'popup-window)
 
   ;; Ensure todo, agenda, and other minor popups are delegated to the popup system.
-  (defun +popup*org-pop-to-buffer (orig-fn buf &optional norecord)
+  (def-advice! +popup-org-pop-to-buffer-a (orig-fn buf &optional norecord)
     "Use `pop-to-buffer' instead of `switch-to-buffer' to open buffer.'"
+    :around #'org-switch-to-buffer-other-window
     (if +popup-mode
         (pop-to-buffer buf nil norecord)
       (funcall orig-fn buf norecord)))
-  (advice-add #'org-switch-to-buffer-other-window :around #'+popup*org-pop-to-buffer)
 
   ;; `org-agenda'
   (setq org-agenda-window-setup 'popup-window
         org-agenda-restore-windows-after-quit nil)
   ;; Don't monopolize the frame!
-  (defun +popup*org-agenda-suppress-delete-other-windows (orig-fn &rest args)
+  (def-advice! +popup-org-agenda-suppress-delete-other-windows-a (orig-fn &rest args)
+    :around #'org-agenda-prepare-window
     (cond ((not +popup-mode)
            (apply orig-fn args))
           ((eq org-agenda-window-setup 'popup-window)
@@ -307,18 +303,16 @@ instead of switch-to-buffer-*."
                         (symbol-function 'ignore)))
                (apply orig-fn args))))
           ((with-popup-rules! nil
-             (apply orig-fn args)))))
-  (advice-add #'org-agenda-prepare-window :around #'+popup*org-agenda-suppress-delete-other-windows))
+             (apply orig-fn args))))))
 
 
 ;;;###package persp-mode
-(progn
-  (defun +popup*persp-mode-restore-popups (&rest _)
-    "Restore popup windows when loading a perspective from file."
-    (dolist (window (window-list))
-      (when (+popup-parameter 'popup window)
-        (+popup--init window nil))))
-  (advice-add #'persp-load-state-from-file :after #'+popup*persp-mode-restore-popups))
+(def-advice! +popup--persp-mode-restore-popups-a (&rest _)
+  "Restore popup windows when loading a perspective from file."
+  :after #'persp-load-state-from-file
+  (dolist (window (window-list))
+    (when (+popup-parameter 'popup window)
+      (+popup--init window nil))))
 
 
 ;;;###package pdf-tools
@@ -340,11 +334,11 @@ instead of switch-to-buffer-*."
 
 
 ;;;###package profiler
-(defun doom*profiler-report-find-entry-in-other-window (orig-fn function)
+(def-advice! +popup--profiler-report-find-entry-in-other-window-a (orig-fn function)
+  :around #'profiler-report-find-entry
   (cl-letf (((symbol-function 'find-function)
              (symbol-function 'find-function-other-window)))
     (funcall orig-fn function)))
-(advice-add #'profiler-report-find-entry :around #'doom*profiler-report-find-entry-in-other-window)
 
 
 ;;;###package wgrep
@@ -370,17 +364,13 @@ instead of switch-to-buffer-*."
 
 
 ;;;###package windmove
-(progn
-  ;; Users should be able to hop into popups easily, but Elisp shouldn't.
-  (defun doom*ignore-window-parameters (orig-fn &rest args)
-    "Allow *interactive* window moving commands to traverse popups."
-    (cl-letf (((symbol-function #'windmove-find-other-window)
-               (lambda (dir &optional arg window)
-                 (window-in-direction
-                  (pcase dir (`up 'above) (`down 'below) (_ dir))
-                  window (bound-and-true-p +popup-mode) arg windmove-wrap-around t))))
-      (apply orig-fn args)))
-  (advice-add #'windmove-up :around #'doom*ignore-window-parameters)
-  (advice-add #'windmove-down :around #'doom*ignore-window-parameters)
-  (advice-add #'windmove-left :around #'doom*ignore-window-parameters)
-  (advice-add #'windmove-right :around #'doom*ignore-window-parameters))
+;; Users should be able to hop into popups easily, but Elisp shouldn't.
+(def-advice! doom--ignore-window-parameters-a (orig-fn &rest args)
+  "Allow *interactive* window moving commands to traverse popups."
+  :around '(windmove-up windmove-down windmove-left windmove-right)
+  (cl-letf (((symbol-function #'windmove-find-other-window)
+             (lambda (dir &optional arg window)
+               (window-in-direction
+                (pcase dir (`up 'above) (`down 'below) (_ dir))
+                window (bound-and-true-p +popup-mode) arg windmove-wrap-around t))))
+    (apply orig-fn args)))